BUG: jackdmp: jack_port_get_connections()

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

BUG: jackdmp: jack_port_get_connections()

juuso.alasuutari (Bugzilla)
I found a bug in jack-keyboard, which Edward Tomasz Napierala (trasz)
concluded is actually a bug in how jackdmp implements
jack_port_get_connections().

This is the code in jack-keyboard that works with jackd but causes a
segfault with jackdmp:

connected = jack_port_get_connections(output_port);
<...snip...>
   if (connected != NULL && !strcmp(available[i], connected[0]))

The JACK API docs say that jack_port_get_connections() is supposed to:

"@return a null-terminated array of full port names to which the port is
connected. If none, returns NULL."

Jackdmp, however, returns a pointer to an empty struct if there are no
connections.

Juuso

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Jackit-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jackit-devel
Reply | Threaded
Open this post in threaded view
|

Re: BUG: jackdmp: jack_port_get_connections()

Stéphane Letz

Le 11 mars 08 à 16:37, Juuso Alasuutari a écrit :

> I found a bug in jack-keyboard, which Edward Tomasz Napierala (trasz)
> concluded is actually a bug in how jackdmp implements
> jack_port_get_connections().
>
> This is the code in jack-keyboard that works with jackd but causes a
> segfault with jackdmp:
>
> connected = jack_port_get_connections(output_port);
> <...snip...>
>   if (connected != NULL && !strcmp(available[i], connected[0]))
>
> The JACK API docs say that jack_port_get_connections() is supposed to:
>
> "@return a null-terminated array of full port names to which the  
> port is
> connected. If none, returns NULL."
>
> Jackdmp, however, returns a pointer to an empty struct if there are no
> connections.
>
> Juuso
>
> -

Should be fixed on SVN. Can you test again?

Thanks

Stephane
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Jackit-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jackit-devel
Reply | Threaded
Open this post in threaded view
|

Re: BUG: jackdmp: jack_port_get_connections()

juuso.alasuutari (Bugzilla)
Stéphane Letz wrote:

>
> Le 11 mars 08 à 16:37, Juuso Alasuutari a écrit :
>> The JACK API docs say that jack_port_get_connections() is supposed to:
>>
>> "@return a null-terminated array of full port names to which the port is
>> connected. If none, returns NULL."
>>
>> Jackdmp, however, returns a pointer to an empty struct if there are no
>> connections.
>>
>> Juuso
>>
>> -
>
> Should be fixed on SVN. Can you test again?
>
> Thanks
>
> Stephane

It does work now, thanks! And sorry for the latency of my reply. :)

Juuso

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Jackit-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jackit-devel