[Jack-Devel] possible copy&paste style bugs?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Jack-Devel] possible copy&paste style bugs?

Markus Grabner
        Hi!

I came across several locations in the Jack source code which look like
copy&paste style bugs (see attached diff). Maybe someone familiar with the
code can review these?

        Thanks & kind regards,
                Markus

_______________________________________________
Jack-Devel mailing list
[hidden email]
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org

changes.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: possible copy&paste style bugs?

Kjetil Matheussen-2
I don't know the source very well, but I would be surprised if any of those three are not real bugs that you have found.


On Tue, Dec 19, 2017 at 10:27 PM, Markus Grabner <[hidden email]> wrote:
        Hi!

I came across several locations in the Jack source code which look like
copy&paste style bugs (see attached diff). Maybe someone familiar with the
code can review these?

        Thanks & kind regards,
                Markus

_______________________________________________
Jack-Devel mailing list
[hidden email]
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org



_______________________________________________
Jack-Devel mailing list
[hidden email]
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org
Reply | Threaded
Open this post in threaded view
|

Re: possible copy&paste style bugs?

Stéphane Letz
In reply to this post by Markus Grabner
copy&paste style bugs for sure. Please commit the patch, thanks.

Stéphane


> Le 19 déc. 2017 à 22:27, Markus Grabner <[hidden email]> a écrit :
>
> Hi!
>
> I came across several locations in the Jack source code which look like
> copy&paste style bugs (see attached diff). Maybe someone familiar with the
> code can review these?
>
> Thanks & kind regards,
> Markus
> <changes.diff>_______________________________________________
> Jack-Devel mailing list
> [hidden email]
> http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org

_______________________________________________
Jack-Devel mailing list
[hidden email]
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org
Reply | Threaded
Open this post in threaded view
|

Re: possible copy&paste style bugs?

Markus Grabner
Am Dienstag, 19. Dezember 2017, 22:55:58 CET schrieb Stéphane Letz:
> copy&paste style bugs for sure. Please commit the patch, thanks.
I don't have write permissions to the jack git repository, I created a pull
request instead:

https://github.com/jackaudio/jack2/pull/317

        Kind regards,
                Markus

_______________________________________________
Jack-Devel mailing list
[hidden email]
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org