Re: [LAD] updates

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [LAD] updates

Adrian Knoth
On Sun, Aug 23, 2015 at 03:49:26PM +0000, Fons Adriaensen wrote:

> I also completely replaced the code in Jack1 that
> calculates the proper running order of clients.
> The previous algorithm failed to do this in some
> cases. It could not be 'fixed' easily as it was
> basically using the wrong algorithm.
>
> Affected files are
>
>         modified:   include/engine.h
>         modified:   include/internal.h
>         modified:   jackd/clientengine.c
>         modified:   jackd/clientengine.h
>         modified:   jackd/engine.c
>
> There seems to be no interest from the Jack devs,
> but if anybody wants to test this I can either
> provide the modified files or a patch against
> git commit 5af5815c47630b77cc71c91a460f8aa398017cf7
> (current HEAD).

Not that I consider myself a jack-dev anymore, but how about you just
share out your patch on jack-devel or as a pull-request on github?

My impression is that somebody is just going to merge it. ;)


Cheers

--
mail: [hidden email]   http://adi.thur.de        PGP/GPG: key via keyserver

_______________________________________________
Jack-Devel mailing list
[hidden email]
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org
Reply | Threaded
Open this post in threaded view
|

Re: [LAD] updates

Paul Davis
Indeed. I'm out for 2 weeks on vacation with only intermittent network
access. Back next week. A pull request or a straightforward patch
would make the next step much easier, but i'll deal with it one way or
another.

On Mon, Aug 24, 2015 at 8:43 AM, Adrian Knoth <[hidden email]> wrote:

> On Sun, Aug 23, 2015 at 03:49:26PM +0000, Fons Adriaensen wrote:
>
>> I also completely replaced the code in Jack1 that
>> calculates the proper running order of clients.
>> The previous algorithm failed to do this in some
>> cases. It could not be 'fixed' easily as it was
>> basically using the wrong algorithm.
>>
>> Affected files are
>>
>>         modified:   include/engine.h
>>         modified:   include/internal.h
>>         modified:   jackd/clientengine.c
>>         modified:   jackd/clientengine.h
>>         modified:   jackd/engine.c
>>
>> There seems to be no interest from the Jack devs,
>> but if anybody wants to test this I can either
>> provide the modified files or a patch against
>> git commit 5af5815c47630b77cc71c91a460f8aa398017cf7
>> (current HEAD).
>
> Not that I consider myself a jack-dev anymore, but how about you just
> share out your patch on jack-devel or as a pull-request on github?
>
> My impression is that somebody is just going to merge it. ;)
>
>
> Cheers
>
> --
> mail: [hidden email]       http://adi.thur.de      PGP/GPG: key via keyserver
>
> _______________________________________________
> Jack-Devel mailing list
> [hidden email]
> http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org
_______________________________________________
Jack-Devel mailing list
[hidden email]
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org
Reply | Threaded
Open this post in threaded view
|

Re: [LAD] updates

Paul Davis
On Tue, Aug 25, 2015 at 3:38 PM, Fons Adriaensen <[hidden email]> wrote:

> On Tue, Aug 25, 2015 at 12:31:13PM -0400, Paul Davis wrote:
>
>> Indeed. I'm out for 2 weeks on vacation with only intermittent network
>> access. Back next week. A pull request or a straightforward patch
>> would make the next step much easier, but i'll deal with it one way or
>> another.
>
> OK, enjoy the off-line time :-) I'll be doing the same from next friday
> until 17 september (Greece, diving).
>
> I'll send you the output of git diff and the modified files, along with
> some notes on how things are supposed to work. There are some open
> questions that only someone very familiar with the code can resolve.

Please send that diff.
_______________________________________________
Jack-Devel mailing list
[hidden email]
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org
Reply | Threaded
Open this post in threaded view
|

Re: [LAD] updates

Paul Davis
repost

On Tue, Sep 15, 2015 at 7:37 AM, Paul Davis <[hidden email]> wrote:

> On Tue, Aug 25, 2015 at 3:38 PM, Fons Adriaensen <[hidden email]> wrote:
>> On Tue, Aug 25, 2015 at 12:31:13PM -0400, Paul Davis wrote:
>>
>>> Indeed. I'm out for 2 weeks on vacation with only intermittent network
>>> access. Back next week. A pull request or a straightforward patch
>>> would make the next step much easier, but i'll deal with it one way or
>>> another.
>>
>> OK, enjoy the off-line time :-) I'll be doing the same from next friday
>> until 17 september (Greece, diving).
>>
>> I'll send you the output of git diff and the modified files, along with
>> some notes on how things are supposed to work. There are some open
>> questions that only someone very familiar with the code can resolve.
>
> Please send that diff.
_______________________________________________
Jack-Devel mailing list
[hidden email]
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org
Reply | Threaded
Open this post in threaded view
|

Re: [LAD] updates

Filipe Coelho
On 18.09.2015 16:04, Paul Davis wrote:

> repost
>
> On Tue, Sep 15, 2015 at 7:37 AM, Paul Davis <[hidden email]> wrote:
>> On Tue, Aug 25, 2015 at 3:38 PM, Fons Adriaensen <[hidden email]> wrote:
>>> On Tue, Aug 25, 2015 at 12:31:13PM -0400, Paul Davis wrote:
>>>
>>>> Indeed. I'm out for 2 weeks on vacation with only intermittent network
>>>> access. Back next week. A pull request or a straightforward patch
>>>> would make the next step much easier, but i'll deal with it one way or
>>>> another.
>>> OK, enjoy the off-line time :-) I'll be doing the same from next friday
>>> until 17 september (Greece, diving).
>>>
>>> I'll send you the output of git diff and the modified files, along with
>>> some notes on how things are supposed to work. There are some open
>>> questions that only someone very familiar with the code can resolve.
>> Please send that diff.

I'd like to see that too.


PS: Please don't top-post ;)

_______________________________________________
Jack-Devel mailing list
[hidden email]
http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org