jackmp: buffer size patch

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

jackmp: buffer size patch

Dmitry Baikov
Hi Stéphane,

Trying to figure out why midi branch does not work, I figured out that
ports were not initialized with the buffer size. So, all midi writes
were rejected because buffer size logically was always 0 frames.
Trying to make a clean fix, I refactored buffer size changing code.
I hope the patch is self explanatory.
The most of it should apply to the trunk. Midi-related part is a tiny
but important one-liner.
As an additional bonus, now SetBufferSize() failures are correctly
processed by alsa driver.

I think changes to other backends will be trivial to do (see
JackAlsaDriver::SetBufferSize).

Feel free to ask any questions.

Dmitry.

P.S. I'll report alsa midi driver porting progress in a separate letter.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Jackit-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jackit-devel

jackmp-buffer-size.patch (10K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: jackmp: buffer size patch

Dmitry Baikov
On 6/11/07, Dmitry Baikov <[hidden email]> wrote:
> The most of it should apply to the trunk.
Trunk-only patch attached (svn diff).

Dmitry.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Jackit-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jackit-devel

jackmp-trunk-buffer-size.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: jackmp: buffer size patch

Stéphane Letz
In reply to this post by Dmitry Baikov

Le 11 juin 07 à 01:45, Dmitry Baikov a écrit :

> Hi Stéphane,
>
> Trying to figure out why midi branch does not work, I figured out that
> ports were not initialized with the buffer size. So, all midi writes
> were rejected because buffer size logically was always 0 frames.
> Trying to make a clean fix, I refactored buffer size changing code.
> I hope the patch is self explanatory.
> The most of it should apply to the trunk. Midi-related part is a tiny
> but important one-liner.
> As an additional bonus, now SetBufferSize() failures are correctly
> processed by alsa driver.
>
> I think changes to other backends will be trivial to do (see
> JackAlsaDriver::SetBufferSize).
>
> Feel free to ask any questions.
>
> Dmitry.
>
> P.S. I'll report alsa midi driver porting progress in a separate  
> letter.
> <jackmp-buffer-size.patch>


Hi Dmitry,

Patch applied with CoreAudio and PortAudio drivers adaptation. Thanks!

Stephane
 
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Jackit-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jackit-devel
Reply | Threaded
Open this post in threaded view
|

Re: jackmp: buffer size patch

Stéphane Letz
In reply to this post by Dmitry Baikov

Le 11 juin 07 à 01:55, Dmitry Baikov a écrit :

> On 6/11/07, Dmitry Baikov <[hidden email]> wrote:
>> The most of it should apply to the trunk.
> Trunk-only patch attached (svn diff).
>
> Dmitry.
> <jackmp-trunk-buffer-size.patch>


Well I prefer not applying too much "specific" changes on the trunk,  
only bug fix for now. We'll merge the midi later on.

Thanks

Stephane
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Jackit-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jackit-devel
Reply | Threaded
Open this post in threaded view
|

Re: jackmp: buffer size patch

Dmitry Baikov
On 6/11/07, Stéphane Letz <[hidden email]> wrote:
> Well I prefer not applying too much "specific" changes on the trunk,
> only bug fix for now. We'll merge the midi later on.
Actually jackmp-trunk-buffer-size.patch is a bug fix only, look at it.


Dmitry.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Jackit-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jackit-devel
Reply | Threaded
Open this post in threaded view
|

Re: jackmp: buffer size patch

Dmitry Baikov
I think JackAlsaDriver::SetBufferSize is a bit wrong,
it should return original error code if buffer size change failed.
Otherwise it will appear to always succeed.


Dmitry.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Jackit-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jackit-devel

jackmp-alsa-restart.patch (926 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: jackmp: buffer size patch

Stéphane Letz
In reply to this post by Dmitry Baikov

Le 11 juin 07 à 11:40, Dmitry Baikov a écrit :

> On 6/11/07, Stéphane Letz <[hidden email]> wrote:
>> Well I prefer not applying too much "specific" changes on the trunk,
>> only bug fix for now. We'll merge the midi later on.
> Actually jackmp-trunk-buffer-size.patch is a bug fix only, look at it.
>
>
> Dmitry.


Ok applied

Stephane
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Jackit-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jackit-devel
Reply | Threaded
Open this post in threaded view
|

Re: jackmp: buffer size patch

Stéphane Letz
In reply to this post by Dmitry Baikov

Le 11 juin 07 à 12:31, Dmitry Baikov a écrit :

> I think JackAlsaDriver::SetBufferSize is a bit wrong,
> it should return original error code if buffer size change failed.
> Otherwise it will appear to always succeed.
>
>
> Dmitry.
> <jackmp-alsa-restart.patch>


Ok applied on midi and trunk.

Stephane
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Jackit-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jackit-devel